[Entitlements] Make lookupImplementationMethod inheritance-aware
#122474
+110
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
approved these changes
Feb 13, 2025
That's because main is "lucky" :) and does not have to support Java < 21. So yes, there is not direct application for this here yet. |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 13, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of 9166b5d
While backporting #122232, I found that it is convenient to change
lookupImplementationMethodto have the same behaviour oflookupMethods; this way the lookup will always find the correct interface, without the need to specify it manually.Since the 2 functions now share the same basic structure, I refactored them to share a common helper and a consistent signature (exception thrown).